Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site #115

Open
wants to merge 143 commits into
base: main
Choose a base branch
from
Open

Site #115

wants to merge 143 commits into from

Conversation

ANazaret
Copy link
Collaborator

@ANazaret ANazaret commented Nov 4, 2024

Time to merge the site branch!

This is now done, no more treeffuser file is impacted by this PR.

As we can see, somehow, the site branch has some commits that modify the treeffuser sourcecode.
Ideally, this PR should not change any treeffuser code.
So let's either discard the unwanted changes or first add the change to the main and merge the main back into the site branch.
Let's merge once no more treeffuser file is impacted.

@ANazaret ANazaret requested a review from velezbeltran November 4, 2024 20:25
docs/bibliography.bib Outdated Show resolved Hide resolved
docs/imgs/img_avatar.png Outdated Show resolved Hide resolved
@velezbeltran
Copy link
Collaborator

Should we merge this?

@ANazaret
Copy link
Collaborator Author

ANazaret commented Dec 3, 2024

It is ready to merge. But once merged, we might have to reconfigure github pages to build the website from main.
(serving the website is already properly configured: the site branch is built into the GitHub-page branch which is then served).
I can look into this carefully in a week.

@velezbeltran
Copy link
Collaborator

velezbeltran commented Dec 3, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants