feat: optional restoring of ComfyUI snapshots to bake custom nodes into the Docker Image #30
Conversation
… a missing "package.json"
* Support network volumes * README tweaks * docs: added comment on what is happening * feat: don't overwrite the default paths, but add "runpod_worker_comfy" to have additional paths * docs: updated "bring your own models" --------- Co-authored-by: Tim Pietrusky <[email protected]>
|
@kklemon Hi - is it possible to provide a little more guidance here? I added a snapshot.json in the root directory, but nothing changed when I built the image in Docker. Thank you |
|
Adding a Edit: Since the Dockerfile uses glob-based file copying, you will need a relatively new Docker installation. I couldn't figure out the exact version, but it should work from Docker version 20 upwards. |
|
Thanks @kklemon - I didn't build the image from scratch, so will try again with your advice |
|
@kklemon thanks for adding this, it sounds really nice. We will have to test this, as this is a feature we haven't used yet. But it sounds like this would solve a lot of problems regarding custom nodes and backing them into the actual Docker image. |
Dockerfile
Outdated
| @@ -39,15 +41,16 @@ RUN if [ -z "$SKIP_DEFAULT_MODELS" ]; then wget -O models/vae/sdxl_vae.safetenso | |||
| RUN if [ -z "$SKIP_DEFAULT_MODELS" ]; then wget -O models/vae/sdxl-vae-fp16-fix.safetensors https://huggingface.co/madebyollin/sdxl-vae-fp16-fix/resolve/main/sdxl_vae.safetensors; fi | |||
| RUN if [ -z "$SKIP_DEFAULT_MODELS" ]; then wget -O models/loras/xl_more_art-full_v1.safetensors https://civitai.com/api/download/models/152309; fi | |||
|
|
|||
| # Support for the network volume | |||
| ADD src/extra_model_paths.yaml ./ | |||
There was a problem hiding this comment.
Why is this removed? As this is also usable for adding models into ComfyUI via the network volume.
| RUN chmod +x /start.sh /restore_snapshot.sh | ||
|
|
||
| # Optionally copy snapshot file | ||
| ADD snapshot.jso[n] / |
There was a problem hiding this comment.
Why would we have jso[n] here when we always expect a json-file?
TimPietrusky
changed the title
|
@kklemon I updated the base branch as we want to move away from having the |
|
@kklemon ping 🙏 |
Motivation
Many users and workflows rely on custom nodes and extensions which correspondingly should also be available in a RunPod worker.
ComfyUI Manager, perhaps the most popular ComfyUI management exension, provides a convenient feature to export a snapshot of the ComfyUI instance with all installed extensions.
This PR implements optional restoring of a snapshot if provided as
snapshot.jsonin the root directory. If such a file is found, ComfyUI Manager will be installed and restoring of the snapshot will be triggered by starting ComfyUI with the--cpu --quick-test-for-ciflags within the Docker image build process.Issues closed
#6 #22 #18 #9 (partially)
Todo