Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB Resolver: set primary name #155

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

pikonha
Copy link
Contributor

@pikonha pikonha commented Jul 29, 2024

DB Resolver: set primary name

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

The flow of fetching the primary name involves calling the Universal Resolver which relies on the resolver(node, encodedFunc) function of the domain's resolver.

The current implementation was causing the resolve with name(bytes32) function encoded as an argument to revert as an OffchainLookup which is supported by the Universal Resolver. However, since the setName cannot be handled off-chain because the ENS contracts don't support the EIP-5559 yet, we had to implement both the setName and name function on-chain. Therefore, we should not revert with OffchainLookup.

Related Issue

#149

Changes

  • New feature implementation
  • Bug fix
  • Code refactoring
  • Documentation update
  • Other (please specify)

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Additional Notes

@pikonha pikonha linked an issue Jul 29, 2024 that may be closed by this pull request
@alextnetto alextnetto merged commit dc0d24f into main Aug 6, 2024
1 check passed
@alextnetto alextnetto deleted the 149-primary-name-registration branch August 6, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SPIKE] Primary name during registration with offchain resolver
2 participants