Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DB Resolver: set primary name
All Submissions:
Description
The flow of fetching the primary name involves calling the Universal Resolver which relies on the
resolver(node, encodedFunc)
function of the domain's resolver.The current implementation was causing the
resolve
withname(bytes32)
function encoded as an argument to revert as anOffchainLookup
which is supported by theUniversal Resolver
. However, since thesetName
cannot be handled off-chain because the ENS contracts don't support the EIP-5559 yet, we had to implement both thesetName
andname
function on-chain. Therefore, we should not revert withOffchainLookup
.Related Issue
#149
Changes
Changes to Core Features:
Additional Notes