Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy multiple contracts #213

Merged
merged 16 commits into from
Oct 3, 2024
Merged

Deploy multiple contracts #213

merged 16 commits into from
Oct 3, 2024

Conversation

pikonha
Copy link
Contributor

@pikonha pikonha commented Sep 23, 2024 •
edited
Loading

Multiple contracts deployment

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

This introduces the DeployerHelper, a script that is used to share contract addresses between multiple scripts, making it easier to deploy huge amounts of contracts.

Related Issue

#191

Changes

  • New feature implementation
  • Bug fix
  • Code refactoring
  • Documentation update
  • Other (please specify)

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Additional Notes

All contracts are deployed and verified in both ETH Sepolia and Arbitrum Sepolia.

@pikonha pikonha added the enhancement New feature or request label Sep 23, 2024
@pikonha pikonha added this to the Deploy to Arbitrum milestone Sep 23, 2024
@pikonha pikonha self-assigned this Sep 23, 2024
@pikonha pikonha marked this pull request as ready for review September 24, 2024 14:44
@pikonha pikonha linked an issue Sep 24, 2024 that may be closed by this pull request
Deploy contract responsible for subdomain registering #191
Closed
3 tasks
@pikonha pikonha removed the request for review from LeonardoVieira1630 September 24, 2024 15:05
alextnetto
alextnetto reviewed Oct 2, 2024
View reviewed changes
Copy link
Member

@alextnetto alextnetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!

Base automatically changed from l2-writing to main October 3, 2024 13:55
@pikonha pikonha merged commit bfa0432 into main Oct 3, 2024
1 check passed
@pikonha pikonha deleted the deploy-multiple-contracts branch October 3, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextnetto alextnetto alextnetto left review comments

Assignees

@pikonha pikonha

Labels
enhancement New feature or request
Projects
ENS
Status: ✅ Done
Milestone
Deploy to Arbitrum
Development

Successfully merging this pull request may close these issues.

Deploy contract responsible for subdomain registering
2 participants
@pikonha @alextnetto