Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: reverts when owner wrongly sends ethers #230

Merged
merged 13 commits into from
Jun 6, 2024
Merged

refactor: reverts when owner wrongly sends ethers #230

merged 13 commits into from
Jun 6, 2024

Conversation

blackbeard002
Copy link
Contributor

closes #227

@blackbeard002 blackbeard002 mentioned this pull request Jun 5, 2024
Closed
2 tasks
@0xneves
Copy link
Contributor

0xneves commented Jun 6, 2024

I took the liberty to:

  • fix cancelSwap (was not sending eth after expiration)
  • feat more tests for cancel swap
  • added more documentation for functions in the interface
  • fixed test names
  • fixed variable names
  • identation

Making a ninja patch because we need this features for yesterday

@0xneves 0xneves merged commit b8a6990 into blockful-io:revision Jun 6, 2024
3 checks passed
@blackbeard002 blackbeard002 deleted the revert branch June 6, 2024 14:35
@blackbeard002 blackbeard002 restored the revert branch June 6, 2024 14:35
@blackbeard002 blackbeard002 deleted the revert branch June 6, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xneves 0xneves Awaiting requested review from 0xneves

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blackbeard002 @0xneves