-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix coverage stats #464
Fix coverage stats #464
Conversation
Codecov Report
@@ Coverage Diff @@
## main #464 +/- ##
==========================================
- Coverage 66.42% 62.28% -4.15%
==========================================
Files 183 225 +42
Lines 2880 3680 +800
Branches 738 891 +153
==========================================
+ Hits 1913 2292 +379
- Misses 740 1094 +354
- Partials 227 294 +67
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this 🎉
I was documenting integration tests and noticed two issues with reported coverage. This PR fixes them.
We used
npx kill-port 3000
in CI, which stoppednext start
with SIGKILL instead of SIGINT. Abrupt process termination meant that the runtime coverage was not reported. I have temporarily replacedyarn kill-port
withkill -2
(i.e. SIGKILL with SIGINT). We can switch back when Add option for kill signal tiaanduplessis/kill-port#48 is closed upstream.↑ this change increased reported code coverage
We did not have
@istanbuljs/nyc-config-typescript
in.nycrc.json
, which caused some source files to be missing from the list of all files. In particular, allsite/src/pages/api/**.ts
files were not included into the report. Adding@istanbuljs/nyc-config-typescript
made the list of files more complete.↑ this change decreased reported code coverage
Overall coverage has decreased, but this is expected.