Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #1073: Updated setup.cfg to require newer scipy version #1081

Merged
merged 4 commits into from
Jul 14, 2024

Conversation

Sarius2009
Copy link
Contributor

No description provided.

@Sarius2009 Sarius2009 changed the title Fixed issue Fixes issue #1073: Updated setup.cfg to require newer scipy version Fixes issue #1073: Updated setup.cfg to require newer scipy version Jun 26, 2024
Copy link
Collaborator

@nils-braun nils-braun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nils-braun nils-braun enabled auto-merge (squash) June 27, 2024 19:01
@nils-braun nils-braun disabled auto-merge June 29, 2024 09:31
@nils-braun
Copy link
Collaborator

@Sarius2009 - it seems there is no such version for older python versions

@Sarius2009
Copy link
Contributor Author

@Sarius2009 - it seems there is no such version for older python versions

Yes, scipy 1.14 requires at least python 3.10

@nils-braun
Copy link
Collaborator

Can you adjust the PR so that your lower limit only applies in this case? tsfresh is also compatible with older versions of python

Added conditional to scipy requirements for different python versions
@Sarius2009
Copy link
Contributor Author

I think I did, hopefully correctly

Copy link
Collaborator

@nils-braun nils-braun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nils-braun nils-braun enabled auto-merge (squash) July 14, 2024 11:17
@nils-braun nils-braun merged commit a2ea97e into blue-yonder:main Jul 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants