-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new UI on Edit Mode #1125
Implement new UI on Edit Mode #1125
Conversation
Signed-off-by: Arturo Manzoli <[email protected]>
350a46f
to
60446ce
Compare
60446ce
to
b14a1d5
Compare
src/components/EditMenu.vue
Outdated
const pickVehicleImage = computed(() => { | ||
switch (store.currentProfile.name.toLowerCase()) { | ||
case 'rov default': | ||
return '../src/assets/vehicles/BlueROV_thumb.png' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use import
keys for this images to avoid possible breaks ? Since images path changes will be detected in compile time. At the moment this is not possible because of computed
.
import RovThumb from '@/src/assets/vehicles/BlueROV_thumb.png'
b14a1d5
to
c83f012
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Clicking the widget gear icon is not opening their configuration menu here.
-
Clicking the mini-widget gear icon is also not opening their configuration menu.
-
Hovering a widget is causing it's entry to highlight, but hovering the entry is not highlighting the widget (on the mini-widgets this is working fine).
-
The highlight are of those two buttons is strange right now, don't know why. One is much bigger than the other, and both are overlapping their neighborhood. Maybe we change the icon color instead of putting an aurea:
- The profile switch floating menu has a very weird background underneath it:
- When the "config profile" button is clicked, the context menu is not being closed:
- The default BlueRobotics logo with the white background is very generating a very weird combination of colors. Could we change it to a transparent-background white logo?
- I think as a user I would expect the carrousel below to be scrollable, although we can open an issue and attack it in a stretch after stable:
- Also as a stretch on a future issue, I think we should make the mini-widget entries also draggable, to have the same pattern as the rest.
Main updates:
(1) |
c83f012
to
c524165
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous points seem indeed to be fixed! I have found only two problems remaining, that were not happening before, both related to the profile change menu:
- The profile-change context menu is apparently broken:
- The icon for the vehicle is also presenting some problem, as it's changing from the default when the profile is selected.
Kapture.2024-07-22.at.10.28.19.mp4
c524165
to
b6a5ea8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome changes!
Implementation based on the Figma mockups developed from the ideas of @ES-Alexander and further developed and debated by the rest of the SW team.
Closes #976