Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new UI on Edit Mode #1125

Conversation

ArturoManzoli
Copy link
Contributor

Implementation based on the Figma mockups developed from the ideas of @ES-Alexander and further developed and debated by the rest of the SW team.

  • Responsiveness to mobile devices will be implemented in a following task.

image

Closes #976

@ArturoManzoli ArturoManzoli force-pushed the 976-Implement-new-UI-edit-mode branch 3 times, most recently from 350a46f to 60446ce Compare July 18, 2024 20:11
@ArturoManzoli ArturoManzoli marked this pull request as draft July 18, 2024 22:46
@ArturoManzoli ArturoManzoli force-pushed the 976-Implement-new-UI-edit-mode branch from 60446ce to b14a1d5 Compare July 19, 2024 17:09
@ArturoManzoli ArturoManzoli marked this pull request as ready for review July 19, 2024 17:12
const pickVehicleImage = computed(() => {
switch (store.currentProfile.name.toLowerCase()) {
case 'rov default':
return '../src/assets/vehicles/BlueROV_thumb.png'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use import keys for this images to avoid possible breaks ? Since images path changes will be detected in compile time. At the moment this is not possible because of computed.

import RovThumb from '@/src/assets/vehicles/BlueROV_thumb.png'

@ArturoManzoli ArturoManzoli force-pushed the 976-Implement-new-UI-edit-mode branch from b14a1d5 to c83f012 Compare July 19, 2024 18:19
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Clicking the widget gear icon is not opening their configuration menu here.

  2. Clicking the mini-widget gear icon is also not opening their configuration menu.

  3. Hovering a widget is causing it's entry to highlight, but hovering the entry is not highlighting the widget (on the mini-widgets this is working fine).

  4. The highlight are of those two buttons is strange right now, don't know why. One is much bigger than the other, and both are overlapping their neighborhood. Maybe we change the icon color instead of putting an aurea:

image
  1. The profile switch floating menu has a very weird background underneath it:
image
  1. When the "config profile" button is clicked, the context menu is not being closed:
image
  1. The default BlueRobotics logo with the white background is very generating a very weird combination of colors. Could we change it to a transparent-background white logo?
image
  1. I think as a user I would expect the carrousel below to be scrollable, although we can open an issue and attack it in a stretch after stable:
image
  1. Also as a stretch on a future issue, I think we should make the mini-widget entries also draggable, to have the same pattern as the rest.

@ArturoManzoli ArturoManzoli marked this pull request as draft July 19, 2024 20:27
@ArturoManzoli
Copy link
Contributor Author

ArturoManzoli commented Jul 22, 2024

Main updates:

  • Fixed responsiveness to HD and HD+ screens
  • Items 1, 2, 3, 5, 6 and 7 from @rafaellehmkuhl review. --> Fixed
  • Item 4 --> Code looks fine. Also not happening on latest cockpit release (1)
  • Items 8 and 9 --> Specific issues created to solve those
  • Integrated widgets configuration dialogs to new interface layout (2)

(1)
https://github.com/user-attachments/assets/8506ca5b-ff68-4f29-adfc-3fc856c4404b

(2)
image

@ArturoManzoli ArturoManzoli force-pushed the 976-Implement-new-UI-edit-mode branch from c83f012 to c524165 Compare July 22, 2024 13:08
@ArturoManzoli ArturoManzoli marked this pull request as ready for review July 22, 2024 13:09
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous points seem indeed to be fixed! I have found only two problems remaining, that were not happening before, both related to the profile change menu:

  1. The profile-change context menu is apparently broken:
image
  1. The icon for the vehicle is also presenting some problem, as it's changing from the default when the profile is selected.
Kapture.2024-07-22.at.10.28.19.mp4

Copy link
Member

@rafaellehmkuhl rafaellehmkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome changes!

@rafaellehmkuhl rafaellehmkuhl merged commit 359c77f into bluerobotics:master Jul 22, 2024
8 checks passed
@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-needed Change needs to be documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement new UI from mockups: Edit Mode
4 participants