-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add telemetry with sentry.io
#1166
Add telemetry with sentry.io
#1166
Conversation
This package will be used for telemetry gattering.
src/main.ts
Outdated
app, | ||
dsn: 'https://5176a29493da4d31a6384c55d291cd3d@o4507692193415168.ingest.us.sentry.io/4507692196036608', | ||
integrations: [Sentry.browserTracingIntegration(), Sentry.replayIntegration()], | ||
tracesSampleRate: 1.0, // Capture 100% of the transactions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is also the option for sampling the errors ( in python it's usually the exceptions ), might be wise to start with a sampled amount if the app produces exceptions very often
https://docs.sentry.io/platforms/javascript/guides/vue/configuration/options/#sample-rate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
Reduced the trace to 10%.
We are trying not to have unhandled errors, so I think for those it's beneficial to keep 100%.
integrations: [Sentry.browserTracingIntegration(), Sentry.replayIntegration()], | ||
tracesSampleRate: 1.0, // Capture 100% of the transactions | ||
tracePropagationTargets: [], | ||
replaysSessionSampleRate: 0.1, // This sets the sample rate at 10%. You may want to change it to 100% while in development and then sample at a lower rate in production. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
never used the replay options ( only available in paid ) but I think itś supposed to generate a "video-like" session of users using the app, looking forward to see it in action :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also curious 👀
Usually depleting the transactions ( tracesSampleRate ) is not a big issue, you just loose performance monitoring, but the errors (sampleRate) should be more carefully managed, specially if we are going to share the account :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e7b9f1a
to
43641c6
Compare
43641c6
to
b9eda55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good for me. Maybe we should also wait for @voorloopnul approval before merging.
b9eda55
to
13ce42f
Compare
It is opt-out by default, but allows disabling it through the development configuration page.