Generate electron-updater metadata
#1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaellehmkuhl
force-pushed
the
generate-electron-update-metadata
branch
from
292cc68
to
7599d3b
Compare
|
It did build normally on my local, but didn't deploy. It's asking for some version on package.json. Am I missing something? I see it deployed normally on the GitHub CI tho. |
This happens because you don't have any tags in your local git repository. After you create one it will work as expected. |
|
Converting back to draft as I noticed the |
rafaellehmkuhl
force-pushed
the
generate-electron-update-metadata
branch
3 times, most recently
from
816f90d
to
b6ed394
Compare
rafaellehmkuhl
force-pushed
the
generate-electron-update-metadata
branch
from
b6ed394
to
1457a87
Compare
|
Fixed. Ready for review. |
The new version fixes the usage of `c.extraMetadata` on Windows
The `latest.yml` files are now generated, pointing to the artifact binaries, with the metadata needed for the `electron-updater` system to work.
rafaellehmkuhl
force-pushed
the
generate-electron-update-metadata
branch
from
1457a87
to
6b81bc3
Compare
ArturoManzoli
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is needed before #1396. It creates a new standard for the binary artifact filenames and generates the
latest.ymlfiles needed for the update system.I made sure everything is right on the PR artifacts, but after we merge it we should check if the release artifacts are also right.The release is also working fine.