Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compass: face-lift widget using canvas #502

Merged

Conversation

rafaellehmkuhl
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl commented Sep 28, 2023

Screen.Recording.2023-09-28.at.18.35.09.mov

I've performed a big face-lift here.
Apart from being prettier, this new compass is also very responsive. All the elements are resized with respect to the widget size, including the font.
It also fixes the problem of the height not being used to resize the canvas.

Fixes #408.
Fixes #501.

@rafaellehmkuhl rafaellehmkuhl force-pushed the new-canvas-compass branch 2 times, most recently from 23d46f2 to 89ae9ea Compare September 28, 2023 21:28
@rafaellehmkuhl rafaellehmkuhl marked this pull request as ready for review September 28, 2023 21:36
@rjehangir
Copy link
Member

I like it a lot! I would like the indicator arrow to be larger and centered like in QGC. I think it is a lot clearer.

@patrickelectric patrickelectric merged commit 3d34a72 into bluerobotics:master Oct 19, 2023
4 checks passed
@patrickelectric patrickelectric deleted the new-canvas-compass branch October 19, 2023 01:05
@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Oct 27, 2023
ES-Alexander added a commit to ES-Alexander/ardusub-zola that referenced this pull request Nov 23, 2023
ES-Alexander added a commit to ES-Alexander/ardusub-zola that referenced this pull request Nov 23, 2023
ES-Alexander added a commit to ES-Alexander/ardusub-zola that referenced this pull request Nov 24, 2023
ES-Alexander added a commit to ES-Alexander/ardusub-zola that referenced this pull request Nov 24, 2023
ES-Alexander added a commit to ES-Alexander/ardusub-zola that referenced this pull request Nov 24, 2023
ES-Alexander added a commit to ES-Alexander/ardusub-zola that referenced this pull request Nov 24, 2023
ES-Alexander added a commit to bluerobotics/ardusub-zola that referenced this pull request Nov 24, 2023
ES-Alexander added a commit to bluerobotics/ardusub-zola that referenced this pull request Nov 24, 2023
ES-Alexander added a commit to bluerobotics/ardusub-zola that referenced this pull request Nov 24, 2023
@ES-Alexander ES-Alexander added docs-complete Change documentation has been completed and removed docs-needed Change needs to be documented labels Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-complete Change documentation has been completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compass widget needs a face-lift Edit Mode: Some widgets aren't resizing with the height.
4 participants