Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix changing to a profile with less views #509

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Fix changing to a profile with less views #509

merged 1 commit into from
Oct 18, 2023

Conversation

rafaellehmkuhl
Copy link
Member

Fix #506

@rafaellehmkuhl
Copy link
Member Author

rafaellehmkuhl commented Oct 18, 2023 •
edited
Loading

@patrickelectric could you check this one? It's the only major bug we have confirmed in Cockpit currently and it's been waiting for 10 days to be merged.

patrickelectric
patrickelectric approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I thought that was already approved

@patrickelectric patrickelectric merged commit e1e6422 into bluerobotics:master Oct 18, 2023
5 checks passed
@rafaellehmkuhl rafaellehmkuhl deleted the fix-profile-change branch October 19, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickelectric patrickelectric patrickelectric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In some unknown situation (maybe creating a new profile?) one cannot change profiles anymore
2 participants
@rafaellehmkuhl @patrickelectric