Skip to content

Commit

Permalink
Some more workflow fixes and updated .mod file (#25)
Browse files Browse the repository at this point in the history
* Update main.yml

Attempt at compiling x86_64 and arm64 together in the same run, hopefully getting a single library compatible with both.

* Update main.yml

Trying wrapping the Maya 2024 macos architectures in quotes to fix build

* Update main.yml

Removing architecture from macos builds as it looks like targeting for both arm and x64 works in a single bundle.

* Update TwistSpline.mod
  • Loading branch information
mdilena authored Dec 4, 2023
1 parent becad5a commit 5efc28c
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 32 deletions.
9 changes: 4 additions & 5 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,6 @@ jobs:
devkit: "https://autodesk-adn-transfer.s3-us-west-2.amazonaws.com/ADN+Extranet/M%26E/Maya/devkit+2022/Autodesk_Maya_2022_5_Update_DEVKIT_Mac.dmg"
- maya: "2023"
devkit: "https://autodesk-adn-transfer.s3-us-west-2.amazonaws.com/ADN+Extranet/M%26E/Maya/devkit+2023/Autodesk_Maya_2023_3_Update_DEVKIT_Mac.dmg"
- maya: "2024"
devkit: "https://autodesk-adn-transfer.s3-us-west-2.amazonaws.com/ADN+Extranet/M%26E/Maya/devkit+2024/Autodesk_Maya_2024_2_Update_DEVKIT_Mac.dmg"

steps:
- name: Checkout code
Expand Down Expand Up @@ -117,10 +115,11 @@ jobs:
- name: Upload Artifacts
uses: actions/upload-artifact@v3
with:
name: mac-${{matrix.maya}}-x86_64
name: mac-${{matrix.maya}}
path: |
artifacts/plug-ins/TwistSpline.bundle
# This will be compiled for both x86_64 and arm64 architectures, as arm support has been added starting from Maya 2024.
maya-macos-arm64:
runs-on: macos-latest

Expand Down Expand Up @@ -149,7 +148,7 @@ jobs:

- name: Configure CMake
run: |
cmake -G Xcode -DCMAKE_OSX_ARCHITECTURES=arm64 -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} -DMAYA_VERSION=${{matrix.maya}} -DMAYA_DEVKIT_BASE="/Volumes/devkitBase"
cmake -G Xcode -DCMAKE_OSX_ARCHITECTURES="x86_64;arm64" -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} -DMAYA_VERSION=${{matrix.maya}} -DMAYA_DEVKIT_BASE="/Volumes/devkitBase"
- name: Build
run: cmake --build ${{github.workspace}}/build --config ${{env.BUILD_TYPE}}
Expand All @@ -162,7 +161,7 @@ jobs:
- name: Upload Artifacts
uses: actions/upload-artifact@v3
with:
name: mac-${{matrix.maya}}-arm64
name: mac-${{matrix.maya}}
path: |
artifacts/plug-ins/TwistSpline.bundle
Expand Down
36 changes: 9 additions & 27 deletions TwistSpline.mod
Original file line number Diff line number Diff line change
@@ -1,30 +1,3 @@
+ PLATFORM:win64 MAYAVERSION:2018 TwistSpline 1.0.0 TwistSpline
plug-ins: windows-2018

+ PLATFORM:linux MAYAVERSION:2018 TwistSpline 1.0.0 TwistSpline
plug-ins: linux-2018

+ PLATFORM:mac MAYAVERSION:2018 TwistSpline 1.0.0 TwistSpline
plug-ins: mac-2018

+ PLATFORM:win64 MAYAVERSION:2019 TwistSpline 1.0.0 TwistSpline
plug-ins: windows-2019

+ PLATFORM:linux MAYAVERSION:2019 TwistSpline 1.0.0 TwistSpline
plug-ins: linux-2019

+ PLATFORM:mac MAYAVERSION:2019 TwistSpline 1.0.0 TwistSpline
plug-ins: mac-2019

+ PLATFORM:win64 MAYAVERSION:2020 TwistSpline 1.0.0 TwistSpline
plug-ins: windows-2020

+ PLATFORM:linux MAYAVERSION:2020 TwistSpline 1.0.0 TwistSpline
plug-ins: linux-2020

+ PLATFORM:mac MAYAVERSION:2020 TwistSpline 1.0.0 TwistSpline
plug-ins: mac-2020

+ PLATFORM:win64 MAYAVERSION:2022 TwistSpline 1.0.0 TwistSpline
plug-ins: windows-2022

Expand All @@ -42,3 +15,12 @@ plug-ins: linux-2023

+ PLATFORM:mac MAYAVERSION:2023 TwistSpline 1.0.0 TwistSpline
plug-ins: mac-2023

+ PLATFORM:win64 MAYAVERSION:2024 TwistSpline 1.0.0 TwistSpline
plug-ins: windows-2024

+ PLATFORM:linux MAYAVERSION:2024 TwistSpline 1.0.0 TwistSpline
plug-ins: linux-2024

+ PLATFORM:mac MAYAVERSION:2024 TwistSpline 1.0.0 TwistSpline
plug-ins: mac-2024

0 comments on commit 5efc28c

Please sign in to comment.