Fixed workflows and missing header in twistSplineNode #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing changes to main.yml to get win/macos workflows kicking off
Changed devkit extraction method on macos, from 7z to mounting volume
Added macos architecture in zip file name
|
Awesome! Thanks for this. Especially for the mac stuff. I have zero clue when it comes to that. I'm going to merge, but I'll hold off on bumping the version because I think there's a bit more work to do for the module setup... and I also have no idea how to differentiate between x86 and arm using a .mod file 🤷 |
|
Completely forgot about the mod file, tried to look up some info but can't really find if there's a way to specify the architecture there, although it doesn't seem so. Will do some more experiment with the actions as I'm hoping it can be compiled with compatibility to both in the same bundle file! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of Changes
Proposed Changes
includethat was preventing from compiling the plug-inwindows-latestandmacos-latestresolved the hanging, while onmacosthe7zcommand to extract the devkit wasn't working anymore, so the dmg is now getting mounted and the build points to the contents of that volume directlyEDIT:
Forgot to mention, also split the macos build into
x86_64andarm_64to compile against new Apple chips in Maya 2024.