Set the habihat icon for the entire QApplication

This makes it so popup dialogs consistently use the same icon including error message boxes.
Remove the old per-window setting of habihat window icon.

hab_gui/cli.py

@@ -46,6 +46,11 @@ def get_application(settings=None, splash=True, **kwargs):
                 _splash = SplashScreen(splash_image)
                 _splash.show()
 
+        # For a consistent UI, set the window icon for the application. All top
+        # level widgets will inherit this automatically unless they override
+        # it themselves.
+        app.setWindowIcon(utils.Paths.icon("habihat.svg"))
+
     return app, _splash
 
 

hab_gui/widgets/custom_variable_editor/custom_variable_editor.py

@@ -28,7 +28,6 @@ def __init__(self, resolver, verbosity=0, parent=None):
         self.resolver = resolver
         self.verbosity = verbosity
         utils.load_ui(__file__, self)
-        self.setWindowIcon(utils.Paths.icon("habihat.svg"))
 
         self.uiAddVariableBTN.setIcon(utils.Paths.icon("plus-thick.svg"))
         self.uiEditCurrentItemBTN.setIcon(utils.Paths.icon("pencil-box-outline.svg"))

hab_gui/windows/alias_launch_window.py

@@ -131,8 +131,6 @@ def process_entry_points(self):
         )
 
     def init_gui(self, uri=None):
-        self.setWindowIcon(utils.Paths.icon("habihat.svg"))
-
         self.main_widget = QtWidgets.QWidget()
         self.layout = QtWidgets.QGridLayout()