Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid internal call to deprecated getVersion() method #770

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

Firehed
Copy link
Contributor

@Firehed Firehed commented Jan 12, 2024

After updating to v0.12.0, I get a deprecation warning emitted when running the shell. I have mine set up in a light Doctrine Console wrapper, though I suspect that's not relevant.

I tested this patch in my local vendor code and saw no negative impact, and it removed the deprecation warning.

After updating to v0.12.0, I get a deprecation warning emitted when running the shell. I have mine set up in a light Doctrine Console wrapper, though I suspect that's not relevant.

I tested this patch in my local vendor code and saw no negative impact, and it removed the deprecation warning.
@bobthecow
Copy link
Owner

Ahh, good catch. The deprecation error is triggered but suppressed, so unless you've set up your own handler via set_error_handler elsewhere (like your light Doctrine Console wrapper) it won't do anything at that point of execution.

@bobthecow bobthecow merged commit 7d7f26d into bobthecow:main Jan 12, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants