Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing arg for getMatches() #817

Merged
merged 1 commit into from
Sep 22, 2024
Merged

Conversation

tareqas
Copy link
Contributor

@tareqas tareqas commented Aug 29, 2024

No description provided.

@bobthecow
Copy link
Owner

Huh. I never even noticed this wasn't populated.

It's also never used in the default matchers, and hasn't been since the initial implementation. At this point I'd consider it unused and deprecated, unless you have a use case for it?

@tareqas
Copy link
Contributor Author

tareqas commented Aug 31, 2024

I need the input exactly as it is, including the same spacing, especially the ending space. Is there any way I can achieve this?

@bobthecow
Copy link
Owner

Sure, I'm open to it. Do you have a specific use case?

@tareqas
Copy link
Contributor Author

tareqas commented Sep 3, 2024

I want to determine if it's a partial or complete token by ending space. Explaining the implications using code would be easy.
I will share the code if I can develop something useful from it.

@tareqas
Copy link
Contributor Author

tareqas commented Sep 19, 2024

@bobthecow I've created this package using this feature. Also, I utilized #819 too

https://github.com/tareqas/psym/blob/v1.0.1/src/TabCompletion/Matcher/SqlDqlMatcher.php

@bobthecow
Copy link
Owner

Thanks! having a concrete use case makes it a lot easier to reason about.

I'll take a look this weekend :)

@bobthecow bobthecow merged commit 535c98d into bobthecow:main Sep 22, 2024
27 checks passed
@bobthecow
Copy link
Owner

psym looks like a great project! is there anything from it that would benefit from moving upstream into psysh itself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants