Skip to content

Commit

Permalink
Merge pull request #151 from bohning/changelog
Browse files Browse the repository at this point in the history
Changelog
  • Loading branch information
bohning authored Aug 23, 2023
2 parents c2989b5 + 7c8d59e commit 25f3c27
Show file tree
Hide file tree
Showing 4 changed files with 40 additions and 7 deletions.
16 changes: 12 additions & 4 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
- name: Install Qt
uses: jurplel/install-qt-action@v3
with:
version: "6.*"
version: "6.5.*"
setup-python: false
- name: Set up Python
uses: actions/setup-python@v4
Expand Down Expand Up @@ -75,8 +75,10 @@ jobs:
with:
name: artifacts
path: |
dist/*
!dist/*.app
dist/*Linux
dist/*.dmg
dist/*.exe
CHANGELOG.md
release:
name: Create release
Expand All @@ -86,6 +88,12 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/download-artifact@v3
- name: Extract Release Notes
id: extract_notes
run: |
awk 'BEGIN { RS="<!-- [0-9]+\\.[0-9]+\\.[0-9]+ -->\\s*"; ORS=""; } NR==2 { print $0; exit; }' artifacts/CHANGELOG.md >CHANGELOG.md
shell: bash
- uses: ncipollo/release-action@v1
with:
artifacts: "artifacts/*"
artifacts: "artifacts/dist/*"
bodyFile: "CHANGELOG.md"
26 changes: 26 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
<!-- 0.2.1 -->

# Changes

## Fixes

- Fixed another error with fetching browser cookies preventing the app to start.

<!-- 0.2.0 -->

# Changes

## Fixes

- Fixed an error which prevented downloads from finishing successfully ("Only valid ISO 639 language values are supported as arguments.")
- Fixed an error with the USDB login when downloading multiple songs concurrently without being logged in, yet.
- Fixed an error which could prevent the app from starting if unable to retrieve browser cookies.
- Fixed some Linux-specific issues and documented requirements (see [README](https://github.com/bohning/usdb_syncer/blob/main/README.md)).
- Fixed wrong songs being matched when finding local songs.
- Fixed downloading from YouTube by updating yt_dlp.
- Fixed shortening URLs in the meta tags dialog.

## Features

- Implemented importing and exporting a list of USDB song ids from .json, .usdb_ids and hyperlink files.
- Added actions to show the current song on USDB and on the local file system.
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ package_dir =
install_requires =
importlib-metadata
wheel
PySide6
PySide6==6.5.*
lxml
beautifulsoup4
requests
Expand Down
3 changes: 1 addition & 2 deletions src/usdb_syncer/settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
from __future__ import annotations

import os
import sqlite3
from enum import Enum
from http.cookiejar import CookieJar
from pathlib import Path
Expand Down Expand Up @@ -222,7 +221,7 @@ def cookies(self) -> CookieJar | None:
assert_never(unreachable)
try:
return function(domain_name=Usdb.DOMAIN)
except (browser_cookie3.BrowserCookieError, sqlite3.Error) as error:
except Exception as error: # pylint: disable=broad-exception-caught
_logger.debug(error)
_logger.warning(f"Failed to retrieve {str(self).capitalize()} cookies.")
return None
Expand Down

0 comments on commit 25f3c27

Please sign in to comment.