Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3112. #3323

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #3112. #3323

wants to merge 1 commit into from

Conversation

abdellahrk
Copy link
Contributor

Add id '1' to the first existing admin or if not available to the current user being created.

@abdellahrk
Fix bolt#3112.
332fd22 
Add id '1' to the first existing admin or if not available to the current user.
@bobdenotter
Copy link
Member

Hmm, I'm not sure this is a good fix.. This will effectively "rename" a user to have id 1. If that specific user already has content, it'll be linked to their id, which would cause that content to be 'orphaned', right?

@abdellahrk
Copy link
Contributor Author

@bobdenotter yes right. Then let us just make the currently created user have the id 1?

@bobdenotter
Copy link
Member

@bobdenotter yes right. Then let us just make the currently created user have the id 1?

Yes, you mean whenever we create a user, to ensure there's one with id 1?

@abdellahrk
Copy link
Contributor Author

Yes, you mean whenever we create a user, to ensure there's one with id 1?

Yes @bobdenotter. Or is there a better solution than this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abdellahrk @bobdenotter