Assume BP Docs is not enabled unless explicitly enabled. #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When BuddyPress Docs, via `bp_docs_get_group_settings()`, cannot find the “bp-docs” groupmeta entry for a group, it assumes that the plugin is active for the group. This causes poor behavior when the groupmeta doesn’t exist. An example is when the plugin is activated after groups are created. Also remove some extra settings checks that are not needed because default values are set in `bp_docs_get_group_settings()`.
When no groupmeta is saved for a group, we assume that bp_docs is enabled, which seems odd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When BuddyPress Docs, via
bp_docs_get_group_settings(), cannot findthe “bp-docs” groupmeta entry for a group, it assumes that the plugin
is active for the group. This causes poor behavior when the groupmeta
doesn’t exist. An example is when the plugin is activated after groups
are created.
Also remove some extra settings checks that are not needed because
default values are set in
bp_docs_get_group_settings().