SettingsUseCase 및 ChangeUserNameUseCase 작성 #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radiantchoi
approved these changes
Nov 30, 2022
|
|
||
| final class SettingsRepositoryImpl: SettingsRepository { | ||
|
|
||
| } |
There was a problem hiding this comment.
구조 바꾼 대로 잘 반영해 주셨군요, 좋습니다.
| func getAutoPlayMode() -> Bool | ||
| func changeAutoPlayMode(to mode: Bool) | ||
| func getDarkMode() -> Int | ||
| func changeDarkMode(to mode: Int) |
There was a problem hiding this comment.
처음엔 change to dark mode여야 하지 않나 했습니다만, 생각해 보니 두 가지가 아닌 세 가지의 상태가 있었죠. 문제없어보입니다.
| return "항상 어둡게" | ||
| } | ||
| } | ||
| } |
| .settingsSwitch(title: "음악 자동 재생", isOn: true), // TODO: isOn은 로컬 디비로부터 불러와야 합니다. | ||
| .settingsActionSheet(title: "다크 모드") | ||
| .settingsSwitch(title: "음악 자동 재생", isOn: settingsUseCase.getAutoPlayMode()), | ||
| .settingsActionSheet(title: "다크 모드", mode: settingsUseCase.getDarkMode()) |
There was a problem hiding this comment.
데이터 소스의 해법을 이렇게 찾으셨군요..! 어쩌면 이것이 PublishSubject보다 좋을지도 모르겠습니다.
rudah7
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
11/30 #125 #126 #127 #128
작업한 내용
SettingsUseCase와 ChangeUserNameUseCase를 작성했습니다.
SettingsUseCase에서 LocalUtilityRepository 메서드를 이용합니다.
getAutoPlayMode(),getDarkMode()메서드를 이용해 지정하여 뷰에 처음 진입했을 때 저장되어 있는 값이 불러와지도록 합니다.