Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MyPage 서버와 연결 및 더미데이터 삭제 #186

Merged
merged 2 commits into from
Dec 8, 2022

Conversation

rudah7
Copy link
Collaborator

@rudah7 rudah7 commented Dec 8, 2022

12/8 #135

작업한 내용

MyPage 서버와 연결 및 더미데이터 삭제

  • 기존에 있던 더미데이터들을 삭제하였습니다.
  • 서버 스키마에 맞춰서 전반적인 DTO 등을 수정하였습니다.

Copy link
Collaborator

@radiantchoi radiantchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

자잘하게 수정할 부분을 제외하고 좋습니다! 마침 지금 바로 하신다고 하니까, 일단 머지해봅시다.

Comment on lines +18 to +19
// TODO: Keychain으로부터 토큰 가져오기
let token = "A1lmMjb2pgNWg6ZzAaPYgMcqRv/8BOyO4U/ui6i/Ic4="
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥲

@@ -113,7 +113,7 @@ final class MyPageViewController: UIViewController {
numberFormatter.numberStyle = .decimal

let price = Double(writtenDiary)
let result = numberFormatter.string(from: NSNumber(value:price!))! + "개"
let result = numberFormatter.string(from: NSNumber(value:price))! + "개"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

force unwrapping은 최대한 피하는 것이 좋을 것 같습니다!!
?? "0" 같은 방법으로 처리해도 좋을 것 같네요.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정했습니다~

Copy link
Member

@LEEYOONJONG LEEYOONJONG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!

@radiantchoi radiantchoi merged commit 4a97fe6 into develop Dec 8, 2022
@rudah7 rudah7 deleted the feature/server-connect branch December 8, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants