Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add forward declaration headers #2940

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

ashtum
Copy link
Collaborator

@ashtum ashtum commented Oct 15, 2024

No description provided.

@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://2940.beastdocs.prtest.cppalliance.org/libs/beast/doc/html/index.html

@ashtum ashtum force-pushed the add-forward-declaration-headers branch from 6f03bb2 to 1045710 Compare October 15, 2024 14:23
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://2940.beastdocs.prtest.cppalliance.org/libs/beast/doc/html/index.html

1 similar comment
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://2940.beastdocs.prtest.cppalliance.org/libs/beast/doc/html/index.html

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.10%. Comparing base (7ce0ebe) to head (5b160d9).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2940   +/-   ##
========================================
  Coverage    93.10%   93.10%           
========================================
  Files          177      177           
  Lines        13656    13656           
========================================
  Hits         12714    12714           
  Misses         942      942           
Files with missing lines Coverage Δ
include/boost/beast/core/detail/clamp.hpp 100.00% <ø> (ø)
include/boost/beast/http/basic_dynamic_body.hpp 96.87% <ø> (ø)
include/boost/beast/http/basic_file_body.hpp 82.92% <ø> (ø)
include/boost/beast/http/buffer_body.hpp 88.63% <ø> (ø)
include/boost/beast/http/empty_body.hpp 85.71% <ø> (ø)
include/boost/beast/http/fields.hpp 100.00% <ø> (ø)
include/boost/beast/http/message.hpp 98.52% <ø> (ø)
include/boost/beast/http/message_generator.hpp 100.00% <ø> (ø)
include/boost/beast/http/parser.hpp 86.95% <ø> (ø)
include/boost/beast/http/serializer.hpp 90.90% <ø> (ø)
... and 2 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ce0ebe...5b160d9. Read the comment docs.

@ashtum ashtum force-pushed the add-forward-declaration-headers branch from 1045710 to 6b2796a Compare October 15, 2024 17:08
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://2940.beastdocs.prtest.cppalliance.org/libs/beast/doc/html/index.html

@ashtum ashtum force-pushed the add-forward-declaration-headers branch from 6b2796a to fdf20da Compare October 16, 2024 08:51
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://2940.beastdocs.prtest.cppalliance.org/libs/beast/doc/html/index.html

@ashtum
Copy link
Collaborator Author

ashtum commented Oct 16, 2024

@vinniefalco, this PR replaces message.hpp with message_fwd.hpp in all body types, eliminating the need for a separate forward declaration header for them. This change can break user code that includes only a body header like string_body.hpp and attempts to construct a message. However, this is unlikely since users typically include parser.hpp, serializer.hpp, or perform read/write operations, where message.hpp is already included in those headers, preventing issues. An alternative would be to add a forward declaration header for each body type, but that approach would be messy and cumbersome to use.
What do you think?

@ashtum ashtum force-pushed the add-forward-declaration-headers branch from fdf20da to d748f82 Compare October 16, 2024 19:45
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://2940.beastdocs.prtest.cppalliance.org/libs/beast/doc/html/index.html

@ashtum ashtum force-pushed the add-forward-declaration-headers branch from d748f82 to 5ef926a Compare October 16, 2024 20:05
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://2940.beastdocs.prtest.cppalliance.org/libs/beast/doc/html/index.html

@ashtum ashtum force-pushed the add-forward-declaration-headers branch from 5ef926a to 407a2bf Compare October 16, 2024 20:27
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://2940.beastdocs.prtest.cppalliance.org/libs/beast/doc/html/index.html

@ashtum ashtum force-pushed the add-forward-declaration-headers branch from 407a2bf to 5b160d9 Compare October 16, 2024 20:51
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://2940.beastdocs.prtest.cppalliance.org/libs/beast/doc/html/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants