Use __apple_build_version__ to detect Apple clang
#487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…since __APPLE__ is defined by both Apple Clang and LLVM.org Clang on Apple platforms.
|
While we're here we should probably update the version check for the newer Xcode releases, as in #488. They had the perfect opportunity to synchronize their version numbers with upstream LLVM starting with 14.0 and they of course didn't take it. (Unrelated, we might want to add macos-13 to GHA.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…since
__APPLE__is defined by both Apple Clang and LLVM.org Clang on Apple platforms (as mentioned by #39 (comment)).This ensures
BOOST_CLANG_VERSIONis defined correctly when using LLVM.org clang.1400001400001400001700034000090001