Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for modular build structure. #233
base: develop
Are you sure you want to change the base?
Add support for modular build structure. #233
Changes from 24 commits
b15ac8d
99ff55c
163988d
b134103
c9e7629
4323254
9cf493d
e41adee
803e7fb
0333e73
e922356
2fa69ed
40bc7c9
747fef3
f96d713
3585ee8
ef26b2f
1590c12
63c262e
c3f43bc
3d42a6c
4e1a3a2
fe85ada
14d7f62
0d1a2b3
bf3c459
9313e79
994a46d
37988de
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of this file? Is it actually needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sets the
address-model
andarchitecture
features to the platform detected values for all the config subprojects. Which is what allows this https://github.com/boostorg/log/pull/233/files#diff-b200e03281a7c4df9a1bfad85a764447a1a56954a2efc88f8ba8c212acb38686R18 to be just fetching the feature value.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought you said these properties are auto-detected and always set now, are they not?
Config projects are used from the main build Jamfile, are these (and all other) properties not forwarded to the config projects when they are compiled? I think, they need to be.