Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require non-const reference to call notify() #79

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

scramsby
Copy link

@scramsby scramsby commented May 8, 2019

This fixes notify() and variables_map::notify() to not require a non-const reference to the variables_map. This is useful if you are passing this object from one module to another and want to trigger handling of those variables in the new module's context without enabling that new module to mutate the shared map's state.

@codecov
Copy link

codecov bot commented May 9, 2019

Codecov Report

Merging #79 into develop will increase coverage by 0.14%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #79      +/-   ##
===========================================
+ Coverage    49.89%   50.03%   +0.14%     
===========================================
  Files           23       23              
  Lines         1385     1387       +2     
  Branches       707      707              
===========================================
+ Hits           691      694       +3     
  Misses         110      110              
+ Partials       584      583       -1
Impacted Files Coverage Δ
include/boost/program_options/variables_map.hpp 78.94% <ø> (+2.47%) ⬆️
src/variables_map.cpp 30.85% <66.66%> (ø) ⬆️
...de/boost/program_options/detail/value_semantic.hpp 43.75% <0%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d95d316...ecfef3d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant