Fix format-security warning in debug.c #130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`g_printerr()` and related take an `fprint()` style format string as first parameter, followed by arguments for that `fprint()` format string – just a string was supplied here. Additionally, `g_printerr()` “should not be used from within libraries.” Instead it’s being replaced here by the `g_message()` convenience macro which also takes care of inserting newlines if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
g_printerr()and related take anfprint()style format string as first parameter, followed by arguments for thatfprint()format string – just a string was supplied here. As this function was only supplying a string, compilers would raise aformat-securitywarning, which is commonly raised as an error (-Werror=format-security), stopping the compilation.Additionally,
g_printerr()“should not be used from within libraries.” Instead, it is being replaced here by theg_message()convenience macro, which also takes care of inserting newlines if needed.