Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi languages support other than C/C++ #254

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

miharahiro
Copy link

The files with the following file extensions are also parsed by the
ctags command with default options for each languages.

.go .java .php .pl .py .rb .rs .sh

The files with the following file extensions are also parsed by the
ctags command with default options for each languages.

  .go .java .php .pl .py .rb .rs .sh
@michaelopdenacker
Copy link

Hi Hiroaki
Thanks for this very interesting commit!
Would you have an open-source project to try it on?
I need a bit of time to review and test it.
Cheers
Michael.

@miharahiro
Copy link
Author

Hi Michael
Thank you for the prompt reply!

I have prepared a temporal project for your reviewing.
The following links are examples of various languages being processed by the elixir with this PR.

http://180.196.25.190:8888/blktrace/blktrace-1.3.0/source/blktrace.c
http://180.196.25.190:8888/blktrace/latest/source/btt/btt_plot.py
http://180.196.25.190:8888/cni/latest/source/scripts/exec-plugins.sh
http://180.196.25.190:8888/brotli/latest/source/go/cbrotli/reader.go
http://180.196.25.190:8888/brotli/latest/source/java/org/brotli/dec/Transform.java

Regards,
Hiroaki Mihara

@miharahiro
Copy link
Author

miharahiro commented Jun 27, 2023

Hi Michael,

It took 3 days to be processed and finally the linux kernel is ready for the review.
The temporal project (kernel) can be directly compared with the original one ( https://elixir.bootlin.com/linux/latest/source )

http://180.196.25.190:8888/kernel/latest/source

Regards,
Hiroaki Mihara

@masatake
Copy link

Search "build_error". With this pull request, elixir lists "build_error" defined in *.rs files.
This is a great appeal point of this pull request.

@@ -28,6 +28,7 @@
<select name="f" title="Restricts search to specific file families">
<option value="A" {% if family=="A" %} selected="selected"{% endif %}>All symbols</option>
<option value="C" {% if family=="C" %} selected="selected"{% endif %}>C/CPP/ASM</option>
<option value="E" {% if family=="E" %} selected="selected"{% endif %}>non C/CPP/ASM</option>
Copy link

@tgross35 tgross35 Oct 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth giving a separate option for all types that are found?

I think it would be useful to have a separate option at least for rust, since blended C+Rust projects are popping up more (including kernel). Maybe for perl and python too, but those are usually standalone scripts (vs. rust being more interconnected like c)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the comments!
Yes, I agree with the suggestions to provide a separate group for each types. The current bootlin/elixir provides searching "All symbols", so after the separations for each types, users can still choose to search within the specific file types or within the whole in the package.

@tgross35
Copy link

@michaelopdenacker since @miharahiro posted live projects to try on, would you be able to review this?

@tgross35
Copy link

Hm actually @miharahiro are the links from #254 (comment) still valid? They do not seem to load for me

@miharahiro
Copy link
Author

The links started with " http://www.mihalabo.com:8888/ " has been recovered from the short maintenance, now its ready for the review.

@michaelopdenacker
Copy link

Hi
Thanks for this contribution.
I hope to have time to review it (and others) this week-end (busy times!)
Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants