Repo tests - conversion to pytest

[bigtedde]

The current repository tests are written with the unittest framework. I have began converting these to pytest, starting with just a few tests so as to make sure I am on the right track with these changes.

Very rough draft, started in a separate test file for now. If I am on the right track I will merge changes into original test file and continue converting.

[codecov-commenter]

Codecov Report

Merging #7626 (7d41fb6) into master (a5c4d0d) will decrease coverage by 0.09%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #7626      +/-   ##
==========================================
- Coverage   83.85%   83.76%   -0.09%     
==========================================
  Files          66       66              
  Lines       11864    11900      +36     
  Branches     2149     2155       +6     
==========================================
+ Hits         9948     9968      +20     
- Misses       1346     1359      +13     
- Partials      570      573       +3     

see 10 files with indirect coverage changes

[ThomasWaldmann]

Can you delete the old tests which these tests replace?

[ThomasWaldmann]

Please rebase on current master.

[ThomasWaldmann]

guess that fixture/contextmanager combination is problematic.

[bigtedde]

This works, however when discussing with @m3nu we were skeptical about including this as it seems like a small project that could be compromised: https://github.com/TvoroG/pytest-lazy-fixture

[m3nu]

Or abandoned and unmaintained, which sadly happens too often for useful packages.

[ThomasWaldmann]

That lazy-fixture project doesn't look like regularly maintained. Last release 3.5y old.

[ThomasWaldmann]

please review these "corruption tests" concerning the correct opening, reopening, closing of the repo, where a commit/rollback happens, that stuff that does not need to be within the repo context is happening outside the repo context.

[bigtedde]

please review these "corruption tests" concerning the correct opening, reopening, closing of the repo, where a commit/rollback happens, that stuff that does not need to be within the repo context is happening outside the repo context.

I am reviewing this now, and will have this taken care of by end of day 👍

[bigtedde]

Hmmm. Windows test didn't pass -

borg.testsuite.archiver.extract_cmd.ArchiverTestCase testMethod=test_sparse_file

It provides assertion error that looks similar to one encountered the other day (something to do with a Location object, iirc)

with open(filename, "rb") as fd:
                # check if file contents are as expected
>               self.assert_equal(fd.read(hole_size), b"\0" * hole_size)
E               AssertionError: b'\x0[8388600 chars]0\x00|\xbe \xe0\xc1\xfcg\xbf\xf1bGF\x931\x8c\x[159271271 chars]\x00' != b'\x0[8388600 chars]0\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\[159383507 chars]\x00'

I looked through the test_spare_file test and couldn't find anything that would have broken from my changes 🤔. Will keep my eyes peeled.

[ThomasWaldmann]

@bigtedde

Hmmm. Windows test didn't pass -
borg.testsuite.archiver.extract_cmd.ArchiverTestCase testMethod=test_sparse_file

see #7616.

[bigtedde]

Made some minor clean up changes today, and after a new commit they got past the spurious Windows tests error.

@ThomasWaldmann I am feeling really good about where we are with this test conversion. Do you have any areas of concern I could address before marking this PR ready for review?

[ThomasWaldmann]

ok, last review, will merge after final fixes.

[ThomasWaldmann]

squash all commits together and keep what looks valuable from all the commit comments?

[ThomasWaldmann]

Thanks!