Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive pytest conversion #7661

Merged
merged 4 commits into from
Jul 10, 2023
Merged

Conversation

bigtedde
Copy link
Contributor

Started with a couple test parameterizations. Will parameterize more tests, trying to ensure I don't impact readability in the process.

@bigtedde
Copy link
Contributor Author

I spent a considerable amount of time trying to parameterize test_get_item_uid_gid, but found it both wasn't easily readable and didn't work.

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2023

Codecov Report

Merging #7661 (c2badbf) into master (a5c4d0d) will decrease coverage by 0.31%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #7661      +/-   ##
==========================================
- Coverage   83.85%   83.54%   -0.31%     
==========================================
  Files          66       66              
  Lines       11864    11864              
  Branches     2149     2149              
==========================================
- Hits         9948     9912      -36     
- Misses       1346     1374      +28     
- Partials      570      578       +8     

see 8 files with indirect coverage changes

Copy link
Member

@ThomasWaldmann ThomasWaldmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess we can merge this, just please move the comment to where it belongs.

src/borg/testsuite/archive.py Outdated Show resolved Hide resolved
@ThomasWaldmann
Copy link
Member

BTW, if you think something is finished, switch it from draft to "ready for review".

@bigtedde bigtedde marked this pull request as ready for review July 10, 2023 22:36
@ThomasWaldmann ThomasWaldmann merged commit 7df34fc into borgbackup:master Jul 10, 2023
11 checks passed
@ThomasWaldmann
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants