Archiver folder - all tests converted from unittest to pytest

[bigtedde]

In this PR, I removed the ArchiverTestCaseBase and all unittest elements from the 32 test files in the archiver folder of the testsuite, converting everything to the pytest framework. I will continue to work on review and refinement.

Any and all feedback is greatly appreciated!

@ThomasWaldmann @m3nu

[bigtedde]

@ThomasWaldmann I think I was misunderstanding you before. I was under the impression you just wanted prefix removed from ArchiverSetup and left in the remote_archiver setup. If you want prefix removed entirely, I think this can be done - everywhere I am currently checking the prefix, I can instead just check if archiver.repository_location.startswith("ssh://__testsuite__")

[ThomasWaldmann]

OK, guess this can be merged soon? The one minor thing I found right now plus the borg.exe testing, anything else?

[bigtedde]

OK, guess this can be merged soon? The one minor thing I found right now plus the borg.exe testing, anything else?

I just pushed the remote_repo boolean check change. Also, with a bit of assistance from Manu I was able to test on the binary and all tests passed without any unexpected behavior.

I do believe these changes are good to merge with your approval. There are the same number of tests, they cover the same amount of code, and they all pass as expected. All the unittest elements have been removed and replaced with pytest, and I believe these changes have left the archiver test suite easier to read and build upon going forward.

[ThomasWaldmann]

LGTM, thanks for refactoring this!

[ThomasWaldmann]

@bigtedde can you try that now? #7722 (comment)

[bigtedde]

A lot of (all?) code is calling this with something like f"--repo={archiver.repo_location}" as first argument.

Considering that we have archiver here, that seems a bit too complicated and redundant as we could also create that argument here.

I searched though the directory and can confirm that all cmd calls are with f"--repo={archiver.repo_location}" as the first argument. It is redundant, and I can create that argument in the cmd function itself.

[bigtedde]

LGTM, thanks for refactoring this!

Thank you for your help and mentoring along the way Thomas. It means a lot to me, and I am very excited to have this merged in!