check --repair fixes shadow_index (1.2-maint) #7897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
still failing here, because it is not.
before this fix, borg check --repair just created an empty shadow index, which can lead to incomplete entries if entries are added later. and such incomplete (but present) entries can lead to compact_segments() resurrecting old PUTs by accidentally dropping related DELs.
ThomasWaldmann
force-pushed
the
check-fixes-shadow-index-1.2
branch
from
096e704
to
a780942
Compare
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## 1.2-maint #7897 +/- ##
=============================================
- Coverage 82.60% 82.57% -0.04%
=============================================
Files 38 38
Lines 10776 10778 +2
Branches 2064 2064
=============================================
- Hits 8902 8900 -2
- Misses 1327 1329 +2
- Partials 547 549 +2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix to
borg check --repairso it will recreate a complete shadow_index inside the hints file.Doing that should fix past issues caused by the double-put bug (see #7896) and by the persistence of the shadow index, which is new since borg 1.2.
When running borg in client/server mode (with a remote repo), the fix needs to get applied repo/server-side.