-
-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quarterly pruning strategy. #8337
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## 1.4-maint #8337 +/- ##
=============================================
- Coverage 82.69% 82.50% -0.20%
=============================================
Files 38 38
Lines 11045 11070 +25
Branches 2122 2128 +6
=============================================
- Hits 9134 9133 -1
- Misses 1345 1368 +23
- Partials 566 569 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extending the tests would be good, so this code gets executed and tested.
e4347e6
to
ef7aed9
Compare
Feedback addressed, tests are coming along and should be done soon (30 mins?). |
ef7aed9
to
5d738f7
Compare
5d738f7
to
0e07ab4
Compare
@ThomasWaldmann Okay to merge if you don't have additional changes requested. |
Same here: port to master required after merge, port to 1.2-maint is very optional, considering this is new functionality and 1.2-maint will be phased out in a while. |
@cr1901 Thanks! |
I'll do the master port now. |
Add 13weekly and 3monthly quarterly pruning strategies.
This implements and would close #4750 as described. It works for my use case, but is not ready to be merged due to no tests and docs, and there are subtleties to be addressed wrt what a quarter year actually means.
To do:
--keep-3monthly
(using the same logic--keep-monthly
does) and--keep-13weekly
(using the ISO 8601 week-based year), maybe get rid of the latter entirely.