Ensure HTML is read as UTF-8 #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that I'm not 100% sure Sphinx only generates UTF-8. In any case, this is what I did to make a particular build work on Windows. Food for thought if nothing else. |
|
Thanks for your contribution! 😃 Technically everything is ok, however we have to stick to some company guidelines before I'm able to merge your commit. Could you please sign your commits (So our DCO check will approve), and also add yourself to the NOTICE.md file in the repo root? |
jaw
force-pushed
the
python_read_text_utf8
branch
6 times, most recently
from
112f9fc
to
30fe129
Compare
|
Done! |
This has been tested on Windows where Python could detect HTML files as a windows codepage rather than UTF-8. As it seems Sphinx generates HTML in UTF-8, it should be safe to enforce it here. Signed-off-by: Jonatan "jaw" Wallmander <[email protected]>
|
Nice thanks!! 👍 |
|
@jaw Thanks a lot for the great contribution. Approved for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been tested on Windows where Python could detect HTML files as a windows codepage
rather than UTF-8.
As it seems Sphinx generates HTML in UTF-8, it should be safe to enforce it here.