Skip to content

Commit

Permalink
Incr 6
Browse files Browse the repository at this point in the history
  • Loading branch information
erikbosch committed Sep 18, 2024
1 parent 87bbd2b commit b168f02
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 7 deletions.
11 changes: 7 additions & 4 deletions databroker/src/grpc/kuksa_val_v2/val.rs
Original file line number Diff line number Diff line change
Expand Up @@ -744,7 +744,6 @@ mod tests {
}
}


// Helper for adding an int32 signal and adding value
async fn helper_add_int32(
broker: &DataBroker,
Expand Down Expand Up @@ -847,7 +846,9 @@ mod tests {

let request = proto::GetValueRequest {
signal_id: Some(proto::SignalId {
signal: Some(proto::signal_id::Signal::Path("test.datapoint1".to_string())),
signal: Some(proto::signal_id::Signal::Path(
"test.datapoint1".to_string(),
)),
}),
};

Expand Down Expand Up @@ -1008,7 +1009,9 @@ mod tests {

let request = proto::GetValueRequest {
signal_id: Some(proto::SignalId {
signal: Some(proto::signal_id::Signal::Path("test.datapoint1".to_string())),
signal: Some(proto::signal_id::Signal::Path(
"test.datapoint1".to_string(),
)),
}),
};

Expand Down Expand Up @@ -1083,7 +1086,7 @@ mod tests {
}
}
}

#[tokio::test]
async fn test_publish_value_signal_id_not_found() {
let broker = DataBroker::default();
Expand Down
6 changes: 3 additions & 3 deletions proto/kuksa/val/v2/types.proto
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ message SignalID {
// Numeric identifier to the signal
// As of today Databroker assigns arbitrary unique numbers to each registered signal
// at startup, meaning that identifiers may change after restarting Databroker.
// A mechanism for static identifiers may be introduced in the future.
// A mechanism for static identifiers may be introduced in the future.
int32 id = 1;
// Full VSS-style path to a specific signal, like "Vehicle.Speed"
// Wildcards and paths to branches are not supported.
Expand Down Expand Up @@ -159,8 +159,8 @@ message ValueRestrictionString {
repeated string allowed_values = 1;
}

// Used to indicate status of a signal in Databroker
// This is given as an alternative to Value, so if there is a valid value
// Used to indicate status of a signal in Databroker
// This is given as an alternative to Value, so if there is a valid value
// ValueFailure shall not be specified.
//
// Scenarios where a signal does not exist or a user does not have access to a signal
Expand Down

0 comments on commit b168f02

Please sign in to comment.