DatePreference ClassCastException fixed and minor improvement #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix, retrieving the value before the preferences page was opened at least once, the getDateFor() would return 1.1.1970 instead of the configured default value in the XML declaration.
When the screen is rotated, it seems that a different state is handed to onRestoreInstanceState(). Using the defaultValue() in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I fixed a ClassCastException in DatePreference which occured if the device was rotated while the DatePreference was shown. I don't know Android well enough to know why the Parcelable state in onRestoreInstanceState is not the correct SavedState class, but I know that the current code must fail with a ClassCastException (you checked for the class, and casted after you knew it wasn't of the correct type).
I also added an overload for getDateFor() that allows specifying a default value to use in case the DatePreference was never opened in a PreferenceScreen before, as in this case it will always use the default value 1970-01-01.
Hope you find the changes useful.
Best regards,
Martin