use Docker instead of BuildKit #506
Conversation
Signed-off-by: Ben Cressey <[email protected]>
There was a problem hiding this comment.
I'd like to hear from @patraw and/or @etungsten about their woes with DOCKER_BUILDKIT to make sure there's not an edge case we're hitting.
This comment has been minimized.
This comment has been minimized.
bcressey
force-pushed
the
docker-build
branch
from
e425f83 to
6419712
Compare
|
Added a fix for concurrent builds on the same host, and switched to |
bcressey
force-pushed
the
docker-build
branch
from
6419712 to
1dd1528
Compare
bcressey
force-pushed
the
docker-build
branch
from
1dd1528 to
0d8965e
Compare
Done. I also filled in a |
bcressey
force-pushed
the
docker-build
branch
from
0d8965e to
1f48330
Compare
|
Backed out |
What was the reasoning there? I think I missed this conversation. |
Essentially, the desire to have changelog entries written by the same author, so the voice and focus would be consistent. |
bcressey
force-pushed
the
docker-build
branch
from
4340a6d to
766df7c
Compare
Newer versions of Docker have BuildKit integrated, and we already depend on Docker to provide some of our build tools. BuildKit's ability to copy files directly out of a build image is convenient, but we can work around that using Docker functionality, and eliminate the need to run another daemon for builds. Signed-off-by: Ben Cressey <[email protected]>
Signed-off-by: Ben Cressey <[email protected]>
Although the cache volume was previously created and was functional, the subsequent build stage could not see the expected marker file under either Docker 18.09 and 19.03. With this change, the marker file is now visible, which verifies that we are using the cache volume that matches the build stage. This is a follow-up to the fix in f5c863c. Signed-off-by: Ben Cressey <[email protected]>
bcressey
force-pushed
the
docker-build
branch
from
766df7c to
15f4d49
Compare
PR #506 switches us away from needing a daemon running. Signed-off-by: Jacob Vallejo <[email protected]>
Issue #, if available:
#470
Description of changes:
Switch to the version of BuildKit integrated with Docker to simplify the build requirements.
Testing done:
Ran
cargo make clean && cargo make world; build succeeded.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.