Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk v0.0.2 (Rust v1.40.0) #603

Merged
merged 6 commits into from
Dec 20, 2019
Merged

sdk v0.0.2 (Rust v1.40.0) #603

merged 6 commits into from
Dec 20, 2019

Conversation

iliana
Copy link
Contributor

@iliana iliana commented Dec 20, 2019

Issue #, if available: fixes #600

Description of changes:
The primary change here is Rust v1.40.0:

$ docker run --rm -it thar/sdk-x86_64:0.0.2
[builder@589ff05972bc /]$ rustc -V
rustc 1.40.0

but there's a number of commits here cherry-picked off my WIP license compliance branch, which just help some of the papercuts I experienced while working on the SDK container. The main one is splitting up the hashes file so that adding a single hash doesn't rebuild the entire thing from scratch.

I've already published the image to the lookaside cache so CI can presumably try it out. An image built from this branch joined my cluster and runs pods just fine.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Adding or changing a hash rebuilds the entire SDK, which slows down
iteration.
ftpmirror.gnu.org points to some flaky mirrors, so let's override it to
a more reliable one.
Copy link
Contributor

@zmrow zmrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎄

@@ -15,6 +15,8 @@ RUN \
dnf clean all && \
useradd builder

# =^..^= =^..^= =^..^= =^..^= =^..^= =^..^= =^..^= =^..^= =^..^=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸

@iliana iliana merged commit 4542d78 into develop Dec 20, 2019
@tjkirch tjkirch deleted the sdk-v0.0.2 branch January 2, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rust v1.40
3 participants