Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipeline tooling for signing tool #654

Merged
merged 1 commit into from
Jan 17, 2020
Merged

Add pipeline tooling for signing tool #654

merged 1 commit into from
Jan 17, 2020

Conversation

zmrow
Copy link
Contributor

@zmrow zmrow commented Jan 15, 2020

Issue #, if available:
Related to #592 and #608

Description of changes:

  • Add the buildspec for the "signing" stage in the pipeline
  • Update the Dockerfile for the "builder" container to include the signing tool
  • Include a wrapper script for the signing tool
  • Update the Makefile to build with the root of the Thar repo as its base context.

Testing done:
Once the container finishes building I can test the tooling.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@zmrow
Copy link
Contributor Author

zmrow commented Jan 15, 2020

Renamed the wrapper script with skewers to be more uniform with the rest of the tooling.

Copy link
Member

@jahkeup jahkeup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of things that'll keep the wrapper from running, let's get that fixed and get rolling

tools/infra/container/runtime/bin/sign-tuf-repo Outdated Show resolved Hide resolved
tools/infra/container/Makefile Show resolved Hide resolved
tools/infra/container/runtime/bin/sign-tuf-repo Outdated Show resolved Hide resolved
@zmrow zmrow force-pushed the signing-tool-infra branch from 4bec950 to c29c6ab Compare January 15, 2020 22:16
@zmrow
Copy link
Contributor Author

zmrow commented Jan 15, 2020

Address @etungsten and @jahkeup 's comments

Copy link
Member

@jahkeup jahkeup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer that we didn't bundle the builder environment work in the base stage, can we move that to a different stage? I left an example of what I mean and one way that this could be done in the review comments.

tools/infra/container/runtime/bin/sign-tuf-repo Outdated Show resolved Hide resolved
@zmrow zmrow force-pushed the signing-tool-infra branch from c29c6ab to 78d9bcc Compare January 16, 2020 19:50
@zmrow
Copy link
Contributor Author

zmrow commented Jan 16, 2020

Updated the Dockerfile per @jahkeup and fix the type in sign-tuf-repo

Copy link
Member

@jahkeup jahkeup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to expand the indirection handling in the wrapper to make it clearer at higher level "call sites" that we're passing a variable name down into the build. This also gives us a chance to add some quick checks too that can be caught before entering the signing code.

tools/infra/container/Dockerfile.builder Show resolved Hide resolved
tools/infra/container/runtime/bin/sign-tuf-repo Outdated Show resolved Hide resolved
tools/infra/container/Makefile Show resolved Hide resolved
@zmrow zmrow force-pushed the signing-tool-infra branch from 78d9bcc to d4632f3 Compare January 16, 2020 21:54
@zmrow
Copy link
Contributor Author

zmrow commented Jan 16, 2020

Address @jahkeup 's comments!

Copy link
Member

@jahkeup jahkeup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's get this built into the container and tested in the pipeline!

@jahkeup
Copy link
Member

jahkeup commented Jan 16, 2020

@zmrow Github thinks you need to rebase/merge Dockerfile.builder, can you take a look and see what's going on there?

@zmrow zmrow force-pushed the signing-tool-infra branch from d4632f3 to d53c7d7 Compare January 17, 2020 14:38
@zmrow zmrow merged commit 97370d1 into develop Jan 17, 2020
@zmrow zmrow deleted the signing-tool-infra branch January 17, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants