FSR: only set in Gamescope (remove Wine FSR) #2840
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pylint result on modfied files: |
|
(I'm waiting for comments before doing anything else) |
|
No worries. We've been busy for a few months now, so we're taking our time. I'm in a trip |
|
Can you resolve the conflicts? I did it locally, but I can't figure out how to push it directly to the MR. |
|
Thanks |
TheEvilSkeleton
suggested changes
Jul 30, 2023
|
One last note. Logs now say: (This config is, in fact, not used anymore.) |
|
New:
It adds to the fact that not communicating about Note: Wouldn't it make more sense to have the FSR setting outside of the Gamescope page since it can be used without it? |
|
I think it would be better if we only dealed with gamescope FSR, as Wine FSR can be finnicky, and as you just saw, varies between versions. So we can keep it in the gamescope menu, and remove it otherwise. |
|
Rebased and addressed #3065. |
|
Needs a quick look over from @mirkobrombin, otherwise I'd like to land this. |
mirkobrombin
approved these changes
Sep 3, 2023
orowith2os
force-pushed
the
fsr-move
branch
from
20c010d
to
16ad245
Compare
orowith2os
approved these changes
Sep 27, 2023
orowith2os
force-pushed
the
fsr-move
branch
from
16ad245
to
7adcb96
Compare
|
SonarQube Quality Gate
|
|
Will test later to make sure FSR works; then I'm merging, with some other fixes, for 51.10. |
|
After investigation, I strongly disagree with the proposal made here of only setting FSR inside gamescope.
Only remains duplicated FSR setting issue, which is a 3 lines fix at most. This proposal only has downsides. |
|
It got disabled by default at the same time it was fixed, so that issue could be closed safely.
It is also easy to call the WINE_FULLSCREEN_FSR situation messy, when in reality this designation only rely on one upstream bug that got fixed in the meantime. Unless there's other major bugs I'm unaware of?
I absolutely agree with this observation. I only disagree with the conclusion: it is fairly common to have a resolution setting/slider in-game. Having FSR kicking in while not on 100% resolution, basically providing minimal visual loss while having better performance, is not as niche as
I invested a lot of time researching the topic and this is something I didn't even know. So, first: thanks for the tip 😅, and second: I think I take no risk saying the vast majority of users may, just like I was 30 seconds ago, not be aware of the existence of this toggle.
I don't understand why you say it needs be in the gamescope's submenu: what is the problem with using the global/program FSR value to decide if FSR is enabled inside gamescope? That's how it is currently done, and while as you pointed out in #2755 some adjustments need to be made, I don't see something inherently wrong with it. Also, something that hasn't been mentioned is that wine FSR is far from exclusive to Wine-GE. For instance the default soda runner also include these patches. They are also enabled by default in upstream wine-tkg, meaning it will be available for any runner using tkg patches, assuming of course the said runner does not explicitly set |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
FSR settings are moved in Gamescope. Wine FSR isn't set anymore.
TL;DR: Right now, FSR is enabled in two places:
First, having two separate FSR "enablers" is messy, as you need logic to avoid enabling both of them at the same time (and Bottles isn't doing that). Considering the options, I opted to simply remove Wine FSR.
Second, the conditions mentioned above aren't communicated at all by having FSR as a standalone setting, which is why I opted to move them into Gamescope's page.
Some comments on why it's a draft:
Type of change
How Has This Been Tested?
Built Bottles myself, tested if the UI was correct, launched a game.