Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add SBOM support #1124

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

theofidry
Copy link
Member

The goal of this PR, at the time of writing, is to assess what is necessary. A few points to consider:

  • This should be a dedicated package (ideally a cyclonedx one)
  • This need to have a config entry (for opt-in/opt-out), probably can default opt-in
  • Need to add support for this in the info/diff command; maybe too verbose for the info command but it can probably say whether a SBOM file has been found and suggest the desired command to view the SBOM
  • à la BoxManifest: maybe a new command can be shown to:
    • render the SBOM in different format
    • extract the SBOM specifically

@theofidry
Copy link
Member Author

theofidry commented Oct 23, 2023

/cc @llaville: as this, currently at least, your work for the most part.

Current status: I have a rough idea of what it takes now. I am however very curious about how this will play with composer/composer#11693.

@llaville I am also curious why you went with installed.php content rather than the composer.lock?

@llaville
Copy link
Contributor

I am also curious why you went with installed.php content rather than the composer.lock ?

Because :

  1. composer.lock is not mandatory and could be ignored (see documentation https://getcomposer.org/doc/06-config.md#lock, and implementation https://github.com/composer/composer/blob/2.6.5/src/Composer/Factory.php#L412-L418)
  2. installed.php is part of Composer Runtime API since v2.0 (https://getcomposer.org/doc/07-runtime.md#installed-versions) and should be always present with a highest priority to composer.lock (see implementation https://github.com/composer/composer/blob/2.6.5/src/Composer/Factory.php#L345-L357)

@theofidry theofidry added this to the Box5 milestone Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants