Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix positioning of color picker #42

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Fix positioning of color picker #42

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4da29d6
Fix positioning of color picker
vesper8 Apr 16, 2024
5fc98da
chore: position below context pad
nikku Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions colors/ColorContextPadProvider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ ColorContextPadProvider.prototype.getMultiElementContextPadEntries = function(el

ColorContextPadProvider.prototype._createPopupAction = function(elements) {

const canvas = this._canvas;
const translate = this._translate;
const contextPad = this._contextPad;
const popupMenu = this._popupMenu;
Expand All @@ -50,7 +49,7 @@ ColorContextPadProvider.prototype._createPopupAction = function(elements) {

// get start popup draw start position
var position = {
...getStartPosition(canvas, contextPad, elements),
...getStartPosition(contextPad, elements),
cursor: {
x: event.x,
y: event.y
Expand All @@ -69,23 +68,18 @@ ColorContextPadProvider.prototype._createPopupAction = function(elements) {

// helpers //////////////////////

function getStartPosition(canvas, contextPad, elements) {
function getStartPosition(contextPad, elements) {

var Y_OFFSET = 5;

var diagramContainer = canvas.getContainer(),
pad = contextPad.getPad(elements).html;
var pad = contextPad.getPad(elements).html;

var diagramRect = diagramContainer.getBoundingClientRect(),
padRect = pad.getBoundingClientRect();

var top = padRect.top - diagramRect.top;
var left = padRect.left - diagramRect.left;
var padRect = pad.getBoundingClientRect();

var pos = {
x: left,
y: top + padRect.height + Y_OFFSET
x: padRect.left,
y: padRect.bottom + Y_OFFSET
};

return pos;
}
}