Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing applying the translate service in some places #51

Closed
Vovamzur opened this issue Jan 22, 2024 · 5 comments · Fixed by #77
Closed

Missing applying the translate service in some places #51

Vovamzur opened this issue Jan 22, 2024 · 5 comments · Fixed by #77
Labels
bug Something isn't working good first issue Good for newcomers i18n spring cleaning Could be cleaned up one day

Comments

@Vovamzur
Copy link
Contributor

Describe the Bug

The translate service is not applied inside the CustomProperties for labels like Custom properties and entries labels, descriptions, and dropdown choices labels.

Also, the translate is not applied in the Template group label, Custom properties for scope <${ type }> .etc

Expected Behavior

Every locale is translated with the help of translate like in all other places

Environment

  • Library version: 1.10.0
@Vovamzur Vovamzur added the bug Something isn't working label Jan 22, 2024
@nikku
Copy link
Member

nikku commented Jan 23, 2024

We happily take a contribution to fix this! 🙂

@nikku nikku added backlog Queued in backlog good first issue Good for newcomers spring cleaning Could be cleaned up one day labels Jan 23, 2024
@Vovamzur
Copy link
Contributor Author

Provide me access, please

@nikku
Copy link
Member

nikku commented Jan 23, 2024

@Vovamzur Our usual way to accept contributions is through a pull request.

@Vovamzur Vovamzur mentioned this issue Mar 21, 2024
Merged
@bpmn-io-tasks bpmn-io-tasks bot removed the backlog Queued in backlog label Mar 21, 2024
@Vovamzur
Copy link
Contributor Author

@nikku PR is ready #77

@fake-join fake-join bot closed this as completed in #77 Apr 22, 2024
barmac pushed a commit that referenced this issue Apr 22, 2024
@Vovamzur @barmac
fix: add missing translate to labels
911ab0b 
Closes #51
@nikku
Copy link
Member

nikku commented Apr 26, 2024

Released v1.15.2 with the fix. Thanks again for your contribution ⭐

@nikku nikku added the i18n label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers i18n spring cleaning Could be cleaned up one day
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix missing applying of the translate service Vovamzur/bpmn-js-element-templates
2 participants
@nikku @Vovamzur