fix missing applying of the translate service
#77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Vovamzur
changed the title
translate servicetranslate service
|
Hi @Vovamzur, thanks for your contribution. Unfortunately, until you sign the CLA, we cannot merge it. |
done |
barmac
reviewed
Apr 22, 2024
| return description && ( | ||
| <Markup | ||
| markup={ sanitizeHTML(description) } | ||
| markup={ sanitizeHTML(translate(description)) } |
There was a problem hiding this comment.
Exactly in the required order. We want to sanitize the translation result :)
barmac
approved these changes
Apr 22, 2024
|
I just noticed that the commit messages did not adhere to the conventional commits guidelines which we follow at bpmn.io. I fixed the commits via 911ab0b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #51