Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove UMD distribution #110

Merged
merged 1 commit into from
Jul 3, 2024
Merged

chore: remove UMD distribution #110

merged 1 commit into from
Jul 3, 2024

Conversation

philippfromme
Copy link
Contributor

@philippfromme philippfromme commented Jul 2, 2024

Closes #109

BREAKING CHANGE: UMD distribution removed; use a bundler instead

Proposed Changes

Removes the UMD distribution which doesn't work due to Preact duplication.

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

Closes #109

BREAKING CHANGE: UMD distribution removed; use a bundler instead
@marstamm
Copy link
Collaborator

marstamm commented Jul 2, 2024

Makes no sense to have UMD for composable libraries

@nikku
Copy link
Member

nikku commented Jul 3, 2024

Let's release this soonish so we can merge. Great change 🏅

@nikku nikku merged commit 3042731 into main Jul 3, 2024
8 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 3, 2024
@nikku nikku deleted the remove-umd branch July 3, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UMD Bundle Broken
3 participants