Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify #78 #80

Merged
merged 10 commits into from
Mar 28, 2024
Merged

Verify #78 #80

merged 10 commits into from
Mar 28, 2024

Conversation

nikku
Copy link
Member

@nikku nikku commented Mar 27, 2024 •
edited
Loading

Closes #78

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Mar 27, 2024
@nikku
Copy link
Member Author

nikku commented Mar 27, 2024

Observation: We added a circuit breaker in the update behavior via f1aa3a3 just to remove it (again) via 3e237c1.

@nikku nikku force-pushed the infinite-loop branch 4 times, most recently from ffa4580 to 93d610e Compare March 28, 2024 07:21
@nikku
Copy link
Member Author

nikku commented Mar 28, 2024

🧠 I've spent some time yesterday evening to investigate the situation. What is on my mind right now:

  • While we have test cases (good!) stuff like e5e6d59 shows that we overall lack some understanding of the underlying principles of chained property updating
  • I'm spending the morning to debug the situation and see if we need to revert to the previous bpmn-js-element-templates version (that included a dedicated circuit breaker) or can move to the new version with my fix.

@philippfromme philippfromme self-requested a review March 28, 2024 08:16
@philippfromme
Copy link
Contributor

👍🏻 for testing all connector templates by default, though I'd expect the connectors to have automated tests for this.

@nikku
Copy link
Member Author

nikku commented Mar 28, 2024

Updated with other test including a minimal repro for #78: 3683975.

@nikku nikku marked this pull request as ready for review March 28, 2024 13:17
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Mar 28, 2024
@nikku nikku merged commit ba4213e into main Mar 28, 2024
6 checks passed
@nikku nikku deleted the infinite-loop branch March 28, 2024 14:36
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippfromme philippfromme Awaiting requested review from philippfromme

Assignees

@nikku nikku

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Infinite loop when applying element template
2 participants
@nikku @philippfromme