2239 text annotation alignment #2241
Open
+88
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikku
reviewed
Sep 30, 2024
lib/features/modeling/behavior/AdaptiveLabelPositioningBehavior.js
Outdated
Show resolved
Hide resolved
4 tasks
abdul99ahad
force-pushed
the
2239-text-annotation-alignment
branch
from
bcb9dcf
to
53ed469
Compare
abdul99ahad
force-pushed
the
2239-text-annotation-alignment
branch
from
f6160b2
to
56fda2e
Compare
bpmn-io-tasks
bot
added
needs review
abdul99ahad
force-pushed
the
2239-text-annotation-alignment
branch
from
56fda2e
to
87b4f7c
Compare
|
Seems like tests fail on MacOS. This happens because elements have slightly different bounds across different OS; usually fixed by allocating additional space in the test case. Can you have a look @abdul99ahad? |
nikku
requested changes
Oct 16, 2024
bpmn-io-tasks
bot
added
in progress
Test is not failing on my macOS. @barmac can you confirm by running the test cases? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2239
Proposed Changes
Text annotation can now co exist with flow element label
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/srtoolCloses {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}Requires upstream: bpmn-io/diagram-js#940