Popup menu search #916
Merged
Popup menu search #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
philippfromme
commented
Jun 5, 2024
philippfromme
commented
- adds ability for popup menu providers to provide custom search
- default search sorts matches by location (when searching for "foo", "foo bar" will appear before "bar foo")
|
Example usage here: https://github.com/camunda/camunda-bpmn-js/pull/367/files#diff-1abbb6d8413b72aac12009eae34de187cdc46f9c9eeb5daad527e5c7c43a8df8R23 Not entirely shure if this is the way to do it or wether we should have separate providers for search similar to: https://github.com/bpmn-io/diagram-js/blob/develop/lib/features/search-pad/SearchPadProvider.ts |
nikku
reviewed
Jun 6, 2024
philippfromme
force-pushed
the
popup-menu-search
branch
2 times, most recently
from
e62a656
to
5f694ad
Compare
philippfromme
force-pushed
the
popup-menu-search
branch
from
5f694ad
to
03f4e2c
Compare
philippfromme
added
ready
|
Released as [email protected]. |
nikku
added a commit
to bpmn-io/bpmn-js
that referenced
this pull request
Sep 13, 2024
This ensures we build upon the new search abstraction, built via bpmn-io/diagram-js#916.
nikku
added a commit
to bpmn-io/bpmn-js
that referenced
this pull request
Sep 13, 2024
This ensures we build upon the new search abstraction, built via bpmn-io/diagram-js#916.
|
Example integration surfaced some issues that we may want to follow-up on: bpmn-io/bpmn-js#2235. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.