test: fix flaky test in literal expression

bpmn-io · Oct 16, 2024 · cb8ef20 · cb8ef20
1 parent e9227ec
commit cb8ef20
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 10 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/dmn-js-literal-expression/package.json b/packages/dmn-js-literal-expression/package.json
@@ -26,6 +26,7 @@
     "literal expression"
   ],
   "devDependencies": {
+    "@testing-library/dom": "^10.4.0",
     "dmn-font": "^0.6.2",
     "inferno-test-utils": "~5.6.2"
   },

diff --git a/packages/dmn-js-literal-expression/test/spec/features/textarea/TextareaEditorSpec.js b/packages/dmn-js-literal-expression/test/spec/features/textarea/TextareaEditorSpec.js
@@ -2,6 +2,8 @@
 
 import { bootstrapModeler, inject } from 'test/helper';
 
+import { waitFor } from '@testing-library/dom';
+
 import { query as domQuery } from 'min-dom';
 
 import { queryEditor } from 'dmn-js-shared/test/util/EditorUtil';
@@ -101,19 +103,19 @@ describe('textarea editor', function() {
     });
 
 
-    it('should pass variables to editor', async function() {
+    it('should pass variables to editor', inject(async function(modeling) {
 
       // given
       const getVariablesSpy = sinon.spy(variableResolver, 'getVariables');
-      const editor = queryEditor('.textarea', testContainer);
-      await changeFocus(editor);
 
       // when
-      await changeInput(document.activeElement, 'Var');
+      modeling.editLiteralExpressionText('Var');
 
       // then
-      expect(getVariablesSpy).to.have.been.called;
-    });
+      await waitFor(() => {
+        expect(getVariablesSpy).to.have.been.called;
+      });
+    }));
   });
 
 });
@@ -128,10 +130,6 @@ async function changeInput(input, value) {
   await act(() => input.textContent = value);
 }
 
-async function changeFocus(editor) {
-  await act(() => editor.focus());
-}
-
 async function act(fn) {
   await fn();
   return new Promise(resolve => {