Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky test in literal expression #910

Merged
merged 2 commits into from
Oct 16, 2024
Merged

test: fix flaky test in literal expression #910

merged 2 commits into from
Oct 16, 2024

Conversation

barmac
Copy link
Member

@barmac barmac commented Oct 16, 2024

Proposed Changes

This attempts to fix the flaky test which has been causing build failures for a while, e.g. https://github.com/bpmn-io/dmn-js/actions/runs/11365121269/job/31612772137?pr=909

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@barmac
Copy link
Member Author

barmac commented Oct 16, 2024

I included d452c8a in this PR so that CI can be green.

@barmac barmac changed the base branch from develop to native-key October 16, 2024 12:22
@barmac barmac requested a review from nikku October 16, 2024 12:22
Base automatically changed from native-key to develop October 16, 2024 12:37
@barmac
Copy link
Member Author

barmac commented Oct 16, 2024

It doesn't fix the problem 🙈

@barmac barmac marked this pull request as draft October 16, 2024 13:03
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Oct 16, 2024
@barmac barmac marked this pull request as ready for review October 16, 2024 13:14
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Oct 16, 2024
@barmac
Copy link
Member Author

barmac commented Oct 16, 2024

@nikku nikku marked this pull request as draft October 16, 2024 13:42
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Oct 16, 2024
@barmac
Copy link
Member Author

barmac commented Oct 16, 2024

I've reworked the test to use the API as there's no need to fiddle with DOM elements.

@barmac barmac marked this pull request as ready for review October 16, 2024 14:23
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Oct 16, 2024
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes 🥇

@nikku nikku merged commit e35ea61 into develop Oct 16, 2024
8 checks passed
@nikku nikku deleted the fix-flaky-test branch October 16, 2024 20:59
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants