-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix flaky test in literal expression #910
Conversation
977a168
to
03e6815
Compare
I included d452c8a in this PR so that CI can be green. |
03e6815
to
74b5a98
Compare
It doesn't fix the problem 🙈 |
74b5a98
to
9f72c23
Compare
There's another flaky test in the project :D |
e48aec0
to
7ed847e
Compare
I've reworked the test to use the API as there's no need to fiddle with DOM elements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great changes 🥇
Proposed Changes
This attempts to fix the flaky test which has been causing build failures for a while, e.g. https://github.com/bpmn-io/dmn-js/actions/runs/11365121269/job/31612772137?pr=909
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/sr
toolCloses {LINK_TO_ISSUE}
orRelated to {LINK_TO_ISSUE}